pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix incorrect logic for determining safe WindowAgg run condition
Date: Fri, 17 Mar 2023 02:50:50 +0000
Message-ID: <E1pd0B7-003vOE-Ku@gemulon.postgresql.org> (raw)

Fix incorrect logic for determining safe WindowAgg run conditions

The logic added in 9d9c02ccd to determine when a qual can be used as a
WindowClause run condition failed to correctly check for subqueries in the
qual.  This was being done correctly for normal subquery qual pushdowns,
it's just that 9d9c02ccd failed to follow the lead on that.

This also fixes various other cases where transforming the qual into a
WindowClause run condition in the subquery should have been disallowed.

Bug: #17826
Reported-by: Anban Company
Discussion: https://postgr.es/m/17826-7d8750952f19a5f5@postgresql.org
Backpatch-through: 15, where 9d9c02ccd was introduced.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/eb7d043c9bbadb75a87385113c578f1b30e9d195

Modified Files
--------------
src/backend/optimizer/path/allpaths.c | 185 ++++++++++++++++++++++------------
src/test/regress/expected/window.out  |  43 +++++---
src/test/regress/sql/window.sql       |  17 +++-
3 files changed, 161 insertions(+), 84 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1pd0B7-003vOE-Ku@gemulon.postgresql.org>
Permalink:  ../E1pd0B7-003vOE-Ku@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pd0B7-003vOE-Ku@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix incorrect logic for determining safe WindowAgg run condition
  In-Reply-To: <E1pd0B7-003vOE-Ku@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox