pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Etsuro Fujita <efujita@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: postgres_fdw: Remove useless if-test in GetConnection().
Date: Fri, 17 Mar 2023 09:21:44 +0000
Message-ID: <E1pd6HP-003xz7-UB@gemulon.postgresql.org> (raw)

postgres_fdw: Remove useless if-test in GetConnection().

Checking whether entry->conn is NULL after doing disconnect_pg_server()
for that entry is pointless, as that function ensures that it is NULL.

Thinko in commit 7fc1a81e4; this would be harmless, so patch HEAD only.

Reviewed-by: Richard Guo and Daniel Gustafsson
Discussion: https://postgr.es/m/CAPmGK169vQ83PQwQkoxO-AK2EeK1EsgsxixedM%2BBLWEAhZ_AqQ%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/39a3bdc9eba50628cecb7e3cada95271180c8744

Modified Files
--------------
contrib/postgres_fdw/connection.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)



Message-ID: <E1pd6HP-003xz7-UB@gemulon.postgresql.org>
Permalink:  ../E1pd6HP-003xz7-UB@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pd6HP-003xz7-UB@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: efujita@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: postgres_fdw: Remove useless if-test in GetConnection().
  In-Reply-To: <E1pd6HP-003xz7-UB@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox