pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve several permission-related error messages.
Date: Fri, 17 Mar 2023 09:39:03 +0000
Message-ID: <E1pd6YB-003y5g-FL@gemulon.postgresql.org> (raw)

Improve several permission-related error messages.

Mainly move some detail from errmsg to errdetail, remove explicit
mention of superuser where appropriate, since that is implied in most
permission checks, and make messages more uniform.

Author: Nathan Bossart <nathandbossart@gmail.com>
Discussion: https://www.postgresql.org/message-id/20230316234701.GA903298@nathanxps13

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/de4d456b406bf502341ef526710d3f764b41e2c8

Modified Files
--------------
contrib/file_fdw/expected/file_fdw.out             |   3 +-
contrib/file_fdw/file_fdw.c                        |  10 +-
contrib/test_decoding/expected/permissions.out     |  12 +-
src/backend/backup/basebackup_server.c             |   4 +-
src/backend/catalog/objectaddress.c                |  16 +-
src/backend/commands/copy.c                        |  12 +-
src/backend/commands/user.c                        | 167 ++++++++++++++++-----
src/backend/replication/slot.c                     |   4 +-
src/backend/storage/ipc/procarray.c                |   4 +-
src/backend/storage/ipc/signalfuncs.c              |  16 +-
src/backend/tcop/utility.c                         |   5 +-
src/backend/utils/init/postinit.c                  |  10 +-
src/backend/utils/misc/guc.c                       |  15 +-
.../dummy_seclabel/expected/dummy_seclabel.out     |   3 +-
.../modules/unsafe_tests/expected/rolenames.out    |   3 +-
src/test/regress/expected/create_role.out          |  80 ++++++----
src/test/regress/expected/dependency.out           |   4 +
src/test/regress/expected/privileges.out           |  23 ++-
18 files changed, 282 insertions(+), 109 deletions(-)



Message-ID: <E1pd6YB-003y5g-FL@gemulon.postgresql.org>
Permalink:  ../E1pd6YB-003y5g-FL@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pd6YB-003y5g-FL@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Improve several permission-related error messages.
  In-Reply-To: <E1pd6YB-003y5g-FL@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox