pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix memory leak in Memoize cache key evaluation
Date: Mon, 20 Mar 2023 00:30:00 +0000
Message-ID: <E1pe3PU-004OgD-1a@gemulon.postgresql.org> (raw)

Fix memory leak in Memoize cache key evaluation

When probing the Memoize cache to check if the current cache key values
exist in the cache, we perform an evaluation of the expressions making up
the cache key before probing the hash table for those values.  This
operation could leak memory as it is possible that the cache key is an
expression which requires allocation of memory, as was the case in bug
17844.

Here we fix this by correctly switching to the per tuple context before
evaluating the cache expressions so that the memory is freed next time the
per tuple context is reset.

Bug: 17844
Reported-by: Alexey Ermakov
Discussion: https://postgr.es/m/17844-d2f6f9e75a622bed@postgresql.org
Backpatch-through: 14, where Memoize was introduced

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/579ee5df14dfcf5213e502bb096121d2249167c2

Modified Files
--------------
src/backend/executor/nodeMemoize.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)



view thread (3+ messages)  latest in thread

Message-ID: <E1pe3PU-004OgD-1a@gemulon.postgresql.org>
Permalink:  ../E1pe3PU-004OgD-1a@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pe3PU-004OgD-1a@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix memory leak in Memoize cache key evaluation
  In-Reply-To: <E1pe3PU-004OgD-1a@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox