pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix netmask handling in inet_minmax_multi_ops
Date: Mon, 20 Mar 2023 09:29:05 +0000
Message-ID: <E1peBpB-004SRt-0U@gemulon.postgresql.org> (raw)

Fix netmask handling in inet_minmax_multi_ops

When calculating distance in brin_minmax_multi_distance_inet(), the
netmask was applied incorrectly. This results in (seemingly) incorrect
ordering of values, triggering an assert.

For builds without asserts this is mostly harmless - we may merge other
ranges, possibly resulting in slightly less efficient index. But it's
still correct and the greedy algorithm doesn't guarantee optimality
anyway.

Backpatch to 14, where minmax-multi indexes were introduced.

Reported by Dmitry Dolgov, investigation and fix by me.

Reported-by: Dmitry Dolgov
Backpatch-through: 14
Discussion: https://postgr.es/m/17774-c6f3e36dd4471e67@postgresql.org

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/6a78a42fea0c457dfee2a5ac5431df02342eafd2

Modified Files
--------------
src/backend/access/brin/brin_minmax_multi.c | 4 ++--
src/test/regress/expected/brin_multi.out    | 6 ++++++
src/test/regress/sql/brin_multi.sql         | 7 +++++++
3 files changed, 15 insertions(+), 2 deletions(-)



view thread (5+ messages)  latest in thread

Message-ID: <E1peBpB-004SRt-0U@gemulon.postgresql.org>
Permalink:  ../E1peBpB-004SRt-0U@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1peBpB-004SRt-0U@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tomas.vondra@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix netmask handling in inet_minmax_multi_ops
  In-Reply-To: <E1peBpB-004SRt-0U@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox