pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Stabilize pg_stat_io writes test
Date: Tue, 21 Mar 2023 01:16:45 +0000
Message-ID: <E1peQcH-004ZK3-3G@gemulon.postgresql.org> (raw)

Stabilize pg_stat_io writes test

Counting writes only for io_context = 'normal' is unreliable, as backends
using a buffer access strategy could flush all of the dirty buffers out from
under the other backends and checkpointer. Change the test to count writes in
any context. This achieves roughly the same coverage anyway.

Reported-by: Justin Pryzby <pryzby@telsasoft.com>
Author: Melanie Plageman <melanieplageman@gmail.com>
Discussion: https://www.postgresql.org/message-id/ZAnWU8WbXEDjrfUE%40telsasoft.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ef719e7b32fc2ec9f78c2d9de099f7d75b61cd1b

Modified Files
--------------
src/test/regress/expected/stats.out | 8 ++++----
src/test/regress/sql/stats.sql      | 9 ++++-----
2 files changed, 8 insertions(+), 9 deletions(-)



Message-ID: <E1peQcH-004ZK3-3G@gemulon.postgresql.org>
Permalink:  ../E1peQcH-004ZK3-3G@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1peQcH-004ZK3-3G@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Stabilize pg_stat_io writes test
  In-Reply-To: <E1peQcH-004ZK3-3G@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox