pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Avoid using atooid for numerical comparisons which arent Oids
Date: Tue, 21 Mar 2023 12:09:26 +0000
Message-ID: <E1peant-004eJ4-PF@gemulon.postgresql.org> (raw)

Avoid using atooid for numerical comparisons which arent Oids

The check for the number of roles in the target cluster for an upgrade
selects the existing roles and performs a COUNT(*) over the result.  A
value of one is the expected query result value indicating that only
the install user is present in the new cluster. The result was converted
with the function for converting a string containing an Oid into a numeric,
which avoids potential overflow but makes the code less readable since
it's not actually an Oid at all.

Discussion: https://postgr.es/m/41AB5F1F-4389-4B25-9668-5C430375836C@yesql.se

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/106f26a849bbb760a270e9a3c586aeb73899e26a

Modified Files
--------------
src/bin/pg_upgrade/check.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



Message-ID: <E1peant-004eJ4-PF@gemulon.postgresql.org>
Permalink:  ../E1peant-004eJ4-PF@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1peant-004eJ4-PF@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: dgustafsson@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Avoid using atooid for numerical comparisons which arent Oids
  In-Reply-To: <E1peant-004eJ4-PF@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox