pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve the naming of Parallel Hash Join phases.
Date: Thu, 23 Mar 2023 00:17:04 +0000
Message-ID: <E1pf8db-004uAq-JL@gemulon.postgresql.org> (raw)

Improve the naming of Parallel Hash Join phases.

* Commit 3048898e dropped -ING from PHJ wait event names.  Update the
  corresponding barrier phases names to match.

* Rename the "DONE" phases to "FREE".  That's symmetrical with
  "ALLOCATE", and names the activity that actually happens in that phase
  (as we do for the other phases) rather than a state.  The bug fixed by
  commit 8d578b9b might have been more obvious with this name.

* Rename the batch/bucket growth barriers' "ALLOCATE" phases to
  "REALLOCATE", a better description of what they do.

* Update the high level comments about phases to highlight phases
  are executed by a single process with an asterisk (mostly memory
  management phases).

No behavior change, as this is just improving internal identifiers.  The
only user-visible sign of this is that a couple of wait events' display
names change from "...Allocate" to "...Reallocate" in pg_stat_activity,
to stay in sync with the internal names.

Reviewed-by: Melanie Plageman <melanieplageman@gmail.com>
Discussion: https://postgr.es/m/CA%2BhUKG%2BMDpwF2Eo2LAvzd%3DpOh81wUTsrwU1uAwR-v6OGBB6%2B7g%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8fba928fd78856712f69d96852f8061e77390fda

Modified Files
--------------
doc/src/sgml/monitoring.sgml            | 20 ++++----
src/backend/executor/nodeHash.c         | 73 +++++++++++++-------------
src/backend/executor/nodeHashjoin.c     | 90 +++++++++++++++++----------------
src/backend/utils/activity/wait_event.c | 12 ++---
src/include/executor/hashjoin.h         | 38 +++++++-------
src/include/utils/wait_event.h          |  4 +-
6 files changed, 119 insertions(+), 118 deletions(-)



Message-ID: <E1pf8db-004uAq-JL@gemulon.postgresql.org>
Permalink:  ../E1pf8db-004uAq-JL@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pf8db-004uAq-JL@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tmunro@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Improve the naming of Parallel Hash Join phases.
  In-Reply-To: <E1pf8db-004uAq-JL@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox