pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve a bit the tests of pg_walinspect
Date: Thu, 23 Mar 2023 02:51:44 +0000
Message-ID: <E1pfB3H-004vFM-Q5@gemulon.postgresql.org> (raw)

Improve a bit the tests of pg_walinspect

This commit improves the tests of pg_walinspect on a few things:
- Remove aggregates for queries that should fail.  If the code is
reworked in such a way that the behavior of these queries is changed,
we would get more input from them, written this way.
- Expect at least one record reported in the valid queries doing scans
across ranges, rather than zero records.
- Adjust a few comments, for consistency.

Author: Bharath Rupireddy
Discussion: https://postgr.es/m/CALj2ACVaoXW3nJD9zq8E66BEf-phgJfFcKRVJq9GXkuX0b3ULQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4f1882b960596c35d62c78fb44e14913eff49a85

Modified Files
--------------
contrib/pg_walinspect/expected/oldextversions.out | 13 +++++----
contrib/pg_walinspect/expected/pg_walinspect.out  | 32 ++++++++++-----------
contrib/pg_walinspect/sql/oldextversions.sql      | 13 +++++----
contrib/pg_walinspect/sql/pg_walinspect.sql       | 34 +++++++++++------------
4 files changed, 47 insertions(+), 45 deletions(-)



Message-ID: <E1pfB3H-004vFM-Q5@gemulon.postgresql.org>
Permalink:  ../E1pfB3H-004vFM-Q5@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pfB3H-004vFM-Q5@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Improve a bit the tests of pg_walinspect
  In-Reply-To: <E1pfB3H-004vFM-Q5@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox