pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jeff Davis <jdavis@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: initdb: replace check_icu_locale() with default_icu_locale().
Date: Tue, 28 Mar 2023 15:25:11 +0000
Message-ID: <E1phBC9-000AYQ-Tb@gemulon.postgresql.org> (raw)

initdb: replace check_icu_locale() with default_icu_locale().

The extra checks done in check_icu_locale() are not necessary. An
existing comment already pointed out that the checks would be done
during post-bootstrap initialization, when the locale is opened by the
backend. This was a mistake in commit 27b62377b4.

This commit creates a simpler function default_icu_locale() to just
return the locale of the default collator.

Discussion: https://postgr.es/m/04182066-7655-344a-b8b7-040b1b2490fb%40enterprisedb.com
Reviewed-by: Peter Eisentraut

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f8ca22295e994338259174e5c66b6b23e5d9b55f

Modified Files
--------------
src/bin/initdb/initdb.c | 56 ++++++++++++++++++++++++-------------------------
1 file changed, 28 insertions(+), 28 deletions(-)



Message-ID: <E1phBC9-000AYQ-Tb@gemulon.postgresql.org>
Permalink:  ../E1phBC9-000AYQ-Tb@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1phBC9-000AYQ-Tb@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: jdavis@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: initdb: replace check_icu_locale() with default_icu_locale().
  In-Reply-To: <E1phBC9-000AYQ-Tb@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox