pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix corner-case planner failure for MERGE.
Date: Tue, 28 Mar 2023 15:39:33 +0000
Message-ID: <E1phBQ3-000Aek-UW@gemulon.postgresql.org> (raw)

Fix corner-case planner failure for MERGE.

MERGE planning could fail with "variable not found in subplan target
list" if the target table is partitioned and all its partitions are
excluded at plan time, or in the case where it has no partitions but
used to have some.  This happened because distribute_row_identity_vars
thought it didn't need to make the target table's reltarget list
fully valid; but if we generate a join plan then that is required
because the dummy Result node's tlist will be made from the reltarget.

The same logic appears in distribute_row_identity_vars in v14,
but AFAICS the problem is unreachable in that branch for lack of
MERGE.  In other updating statements, the target table is always
inner-joined to any other tables, so if the target is known dummy
then the whole plan reduces to dummy, so no join nodes are created.
So I'll refrain from back-patching this code change to v14 for now.

Per report from Alvaro Herrera.

Discussion: https://postgr.es/m/20230328112248.6as34mlx5sr4kltg@alvherre.pgsql

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/bf5c4b3d9da67ab0dd8a5a560804f88370c42866

Modified Files
--------------
src/backend/optimizer/util/appendinfo.c | 10 +++++++---
src/test/regress/expected/merge.out     | 25 +++++++++++++++++++++++++
src/test/regress/sql/merge.sql          | 12 ++++++++++++
3 files changed, 44 insertions(+), 3 deletions(-)



view thread (2+ messages)

Message-ID: <E1phBQ3-000Aek-UW@gemulon.postgresql.org>
Permalink:  ../E1phBQ3-000Aek-UW@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1phBQ3-000Aek-UW@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix corner-case planner failure for MERGE.
  In-Reply-To: <E1phBQ3-000Aek-UW@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox