pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix recent pg_walinspect fpi_length bug.
Date: Tue, 28 Mar 2023 17:55:16 +0000
Message-ID: <E1phDXO-000BYd-PD@gemulon.postgresql.org> (raw)

Fix recent pg_walinspect fpi_length bug.

Commit 0276ae42dd taught pg_walinspect's pg_get_wal_record_info()
function to output NULLs rather than empty strings for its record
description and block_ref output parameters.  However, it inadvertently
moved the function call that sets fpi_length until after it was already
set.  As a result, pg_get_wal_record_info() always output spurious
fpi_length values of 0.

Fix by switching the order back (but keep the behavioral change).

Author: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Discussion: https://postgr.es/m/CAH2-WzkJmgSYkt6-smQ+57SxSmov+EKqFZdSimFewosoL_JKoA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bade01cb4dd88f63bd9024cfdaec3d5001a805f3

Modified Files
--------------
contrib/pg_walinspect/pg_walinspect.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)



Message-ID: <E1phDXO-000BYd-PD@gemulon.postgresql.org>
Permalink:  ../E1phDXO-000BYd-PD@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1phDXO-000BYd-PD@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: pg@bowt.ie, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix recent pg_walinspect fpi_length bug.
  In-Reply-To: <E1phDXO-000BYd-PD@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox