pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove empty function BufmgrCommit().
Date: Wed, 29 Mar 2023 13:17:05 +0000
Message-ID: <E1phVfk-000Jgt-DC@gemulon.postgresql.org> (raw)

Remove empty function BufmgrCommit().

This function has been a no-op for over a decade.  Even if bufmgr
regains a need to be called during commit, it seems unlikely that
the most appropriate call points would be precisely here, so it's not
doing us much good as a placeholder either.  Now, removing it probably
doesn't save any noticeable number of cycles --- but the main call is
inside the commit critical section, and the less work done there the
better.

Matthias van de Meent

Discussion: https://postgr.es/m/CAEze2Wi1=tLKbxZnXzcD+8fYKyKqBtivVakLQC_mYBsP4Y8qVA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/58c9600a9f5818f63712ae4262143c42517dcba7

Modified Files
--------------
src/backend/access/transam/xact.c   | 12 +++---------
src/backend/storage/buffer/bufmgr.c | 10 ----------
src/include/storage/bufmgr.h        |  1 -
3 files changed, 3 insertions(+), 20 deletions(-)



Message-ID: <E1phVfk-000Jgt-DC@gemulon.postgresql.org>
Permalink:  ../E1phVfk-000Jgt-DC@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1phVfk-000Jgt-DC@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove empty function BufmgrCommit().
  In-Reply-To: <E1phVfk-000Jgt-DC@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox