pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix outdated comments regarding TupleTableSlots
Date: Thu, 30 Mar 2023 03:37:30 +0000
Message-ID: <E1phj6P-000PWI-Ai@gemulon.postgresql.org> (raw)

Fix outdated comments regarding TupleTableSlots

The tts_flag is named TTS_FLAG_SHOULDFREE, so use that instead of
TTS_SHOULDFREE, which is the name of the macro that checks for that flag.

Additionally, 4da597edf got rid of the TupleTableSlot.tts_tuple field but
forgot to update a comment which referenced that field.  Fix that.

Reported-by: Zhen Mingyang <zhenmingyang@yeah.net>
Reported-by: Richard Guo <guofenglinux@gmail.com>
Discussion: https://postgr.es/m/1a96696c.9d3.187193989c3.Coremail.zhenmingyang@yeah.net

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/902ecd3bd4e733d273e69fd420df6fab4ffbe79b

Modified Files
--------------
src/backend/executor/execTuples.c |  9 +++++----
src/include/executor/tuptable.h   | 10 +++++-----
2 files changed, 10 insertions(+), 9 deletions(-)



Message-ID: <E1phj6P-000PWI-Ai@gemulon.postgresql.org>
Permalink:  ../E1phj6P-000PWI-Ai@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1phj6P-000PWI-Ai@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix outdated comments regarding TupleTableSlots
  In-Reply-To: <E1phj6P-000PWI-Ai@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox