pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add show_data option to pg_get_wal_block_info.
Date: Fri, 31 Mar 2023 21:03:07 +0000
Message-ID: <E1piLtp-000iYm-S1@gemulon.postgresql.org> (raw)

Add show_data option to pg_get_wal_block_info.

Allow users to opt out of returning FPI data and block data from
pg_get_wal_block_info as an optimization.  Testing has shown that this
can make function execution over twice as fast in some cases.

When pg_get_wal_block_info is called with "show_data := false", it
always returns NULL values for its block_data and block_fpi_data bytea
output parameters.  Nothing else changes.  In particular, the function
will still return the usual per-block summary of block data/FPI space
overhead.  Use of "show_data := false" is therefore feasible with all
queries that don't specifically require these raw binary strings.

Follow-up to recent work in commit 122376f0.  There still hasn't been a
stable release with the pg_get_wal_block_info function, so no bump in
the pg_walinspect extension version.

Per suggestion from Melanie Plageman.

Author: Peter Geoghegan <pg@bowt.ie>
Discussion: https://postgr.es/m/CAAKRu_bJvbcYBRj2cN6G2xV7B7-Ja+pjTO1nEnEhRR8OXYiABA@mail.gmail.com
Discussion: https://postgr.es/m/CAH2-Wzm9shOkEDM10_+qOZkRSQhKVxwBFiehH6EHWQQRd_rDPw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/df4f3ab51730a4cdddfead0b264d394ee4925723

Modified Files
--------------
contrib/pg_walinspect/expected/oldextversions.out |  8 ++++----
contrib/pg_walinspect/expected/pg_walinspect.out  | 10 +++++-----
contrib/pg_walinspect/pg_walinspect--1.0--1.1.sql |  5 +++--
contrib/pg_walinspect/pg_walinspect.c             | 13 ++++++++-----
contrib/pg_walinspect/sql/pg_walinspect.sql       | 10 +++++-----
doc/src/sgml/pgwalinspect.sgml                    | 17 ++++++++++++++---
6 files changed, 39 insertions(+), 24 deletions(-)



Message-ID: <E1piLtp-000iYm-S1@gemulon.postgresql.org>
Permalink:  ../E1piLtp-000iYm-S1@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1piLtp-000iYm-S1@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: pg@bowt.ie, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Add show_data option to pg_get_wal_block_info.
  In-Reply-To: <E1piLtp-000iYm-S1@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox