pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_basebackup: Correct type of WalSegSz
Date: Mon, 03 Apr 2023 05:26:15 +0000
Message-ID: <E1pjChq-0016jF-J7@gemulon.postgresql.org> (raw)

pg_basebackup: Correct type of WalSegSz

The pg_basebackup code had WalSegSz as uint32, whereas the rest of the
code has it as int.  This seems confusing, and using the extra range
wouldn't actually work.

Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discussion: https://www.postgresql.org/message-id/flat/1bf15c7a-0acd-1864-081e-7a28814310fe%40enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1980d3585e3c7fce74b811ca8d77733036cae76c

Modified Files
--------------
src/bin/pg_basebackup/streamutil.c | 2 +-
src/bin/pg_basebackup/streamutil.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)



Message-ID: <E1pjChq-0016jF-J7@gemulon.postgresql.org>
Permalink:  ../E1pjChq-0016jF-J7@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pjChq-0016jF-J7@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: pg_basebackup: Correct type of WalSegSz
  In-Reply-To: <E1pjChq-0016jF-J7@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox