pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Only make buffer strategy for vacuum when it's likely needed
Date: Mon, 03 Apr 2023 07:20:24 +0000
Message-ID: <E1pjEUJ-0017Zh-H0@gemulon.postgresql.org> (raw)

Only make buffer strategy for vacuum when it's likely needed

VACUUM FULL and VACUUM ONLY_DATABASE_STATS will not use the vacuum
strategy ring created in vacuum(), so don't waste effort making it in
those cases.

There are other conceivable cases where the buffer strategy also won't be
used, but those are probably less common and not worth troubling over too
much.  For example VACUUM (PROCESS_MAIN false, PROCESS_TOAST false).
There are other cases too, but many of these are only discovered once
inside vacuum_rel().

Author: Melanie Plageman
Reviewed-by: David Rowley
Discussion: https://postgr.es/m/CAAKRu_ZLRuzkM3zKogiZAz2hUony37yLY4aaLb8fPf8fgqs5Og@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/32fbe0239b03d868744758d5809eaf74f19c924d

Modified Files
--------------
src/backend/commands/vacuum.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)



Message-ID: <E1pjEUJ-0017Zh-H0@gemulon.postgresql.org>
Permalink:  ../E1pjEUJ-0017Zh-H0@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pjEUJ-0017Zh-H0@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Only make buffer strategy for vacuum when it's likely needed
  In-Reply-To: <E1pjEUJ-0017Zh-H0@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox