pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: When using valgrind, log the current query after an error is det
Date: Mon, 03 Apr 2023 14:18:41 +0000
Message-ID: <E1pjL15-001AW0-Ry@gemulon.postgresql.org> (raw)

When using valgrind, log the current query after an error is detected.

In USE_VALGRIND builds, add code to print the text of the current query
to the valgrind log whenever the valgrind error count has increased
during the query.  Valgrind will already have printed its report,
if the error is distinct from ones already seen, so that this works
out fairly well as a way of annotating the log.

Onur Tirtir and Tom Lane

Discussion: https://postgr.es/m/AM9PR83MB0498531E804DC8DF8CFF0E8FE9D09@AM9PR83MB0498.EURPRD83.prod.outlook.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a8a00124f1ddb9c8506ff75317f6dd64cc480e61

Modified Files
--------------
src/backend/tcop/postgres.c | 66 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 66 insertions(+)



Message-ID: <E1pjL15-001AW0-Ry@gemulon.postgresql.org>
Permalink:  ../E1pjL15-001AW0-Ry@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pjL15-001AW0-Ry@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: When using valgrind, log the current query after an error is det
  In-Reply-To: <E1pjL15-001AW0-Ry@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox