pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Make SP-GiST redirect cleanup more aggressive.
Date: Mon, 03 Apr 2023 18:48:22 +0000
Message-ID: <E1pjPE5-001CWl-7x@gemulon.postgresql.org> (raw)

Make SP-GiST redirect cleanup more aggressive.

Commit 61b313e4 made VACUUM pass down a heaprel to index AM bulkdelete
and vacuumcleanup routines.  Although this was primarily intended as
preparation for logical decoding on standbys, it also made it easy to
correct an old deficiency in how we determine how to cleanup SP-GiST
redirect and placeholder tuples.

Pass the heaprel to GlobalVisTestFor() during cleanup of redirect and
placeholder tuples, rather than pessimistically passing NULL.

Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Discussion: https://postgr.es/m/02392033-f030-a3c8-c7d0-5c27eb529fec@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/05a304a855104a8eb6394e044bfbc8e761a4d635

Modified Files
--------------
src/backend/access/spgist/spgvacuum.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)



Message-ID: <E1pjPE5-001CWl-7x@gemulon.postgresql.org>
Permalink:  ../E1pjPE5-001CWl-7x@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pjPE5-001CWl-7x@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: pg@bowt.ie, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Make SP-GiST redirect cleanup more aggressive.
  In-Reply-To: <E1pjPE5-001CWl-7x@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox