pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Make vacuum failsafe_active globally visible
Date: Thu, 06 Apr 2023 23:03:23 +0000
Message-ID: <E1pkYdW-001kmn-27@gemulon.postgresql.org> (raw)

Make vacuum failsafe_active globally visible

While vacuuming a table in failsafe mode, VacuumCostActive should
not be re-enabled.  This currently isn't a problem because vacuum
cost parameters are only refreshed in between vacuuming tables and
failsafe status is reset for every table.

In preparation for allowing vacuum cost parameters to be updated
more frequently, elevate LVRelState->failsafe_active to a global,
VacuumFailsafeActive, which will be checked when determining whether
or not to re-enable vacuum cost-related delays.

Author: Melanie Plageman <melanieplageman@gmail.com>
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Reviewed-by: Robert Haas <robertmhaas@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/CAAKRu_ZngzqnEODc7LmS1NH04Kt6Y9huSjz5pp7%2BDXhrjDA0gw%40m...

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/71a825194fd3f8c084f63bd2b0a8d11d753d25d3

Modified Files
--------------
src/backend/access/heap/vacuumlazy.c | 16 +++++++---------
src/backend/commands/vacuum.c        | 15 +++++++++++++++
src/include/commands/vacuum.h        |  1 +
3 files changed, 23 insertions(+), 9 deletions(-)



Message-ID: <E1pkYdW-001kmn-27@gemulon.postgresql.org>
Permalink:  ../E1pkYdW-001kmn-27@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pkYdW-001kmn-27@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: dgustafsson@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Make vacuum failsafe_active globally visible
  In-Reply-To: <E1pkYdW-001kmn-27@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox