pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add --buffer-usage-limit option to vacuumdb
Date: Fri, 07 Apr 2023 00:47:29 +0000
Message-ID: <E1pkaGF-001lkT-Q7@gemulon.postgresql.org> (raw)

Add --buffer-usage-limit option to vacuumdb

1cbbee033 added BUFFER_USAGE_LIMIT to the VACUUM and ANALYZE commands, so
here we permit that option to be specified in vacuumdb.

In passing, adjust the documents for vacuum_buffer_usage_limit and the
BUFFER_USAGE_LIMIT VACUUM option to mention "kB" rather than "KB".  Do the
same for the ERROR message in ExecVacuum() and
check_vacuum_buffer_usage_limit().  Without that we might tell a user that
the valid minimum value is 128 KB only to reject that because we accept
only "kB" and not "KB".

Also, add a small reminder comment in vacuum.h to try to trigger the
memory of anyone adding new fields to VacuumParams that they might want to
consider if vacuumdb needs to grow a new option too.

Author: Melanie Plageman
Reviewed-by: Justin Pryzby
Reviewed-by: David Rowley
Discussion: https://postgr.es/m/ZAzTg3iEnubscvbf@telsasoft.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ae78cae3be627213528f2e08eb976d6906d754de

Modified Files
--------------
doc/src/sgml/config.sgml             |  4 ++--
doc/src/sgml/ref/vacuumdb.sgml       | 13 +++++++++++++
src/backend/commands/vacuum.c        |  4 ++--
src/bin/scripts/vacuumdb.c           | 26 ++++++++++++++++++++++++++
src/include/commands/vacuum.h        |  3 +++
src/test/regress/expected/vacuum.out |  4 ++--
6 files changed, 48 insertions(+), 6 deletions(-)



Message-ID: <E1pkaGF-001lkT-Q7@gemulon.postgresql.org>
Permalink:  ../E1pkaGF-001lkT-Q7@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pkaGF-001lkT-Q7@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Add --buffer-usage-limit option to vacuumdb
  In-Reply-To: <E1pkaGF-001lkT-Q7@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox