pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix locale-dependent test case.
Date: Fri, 07 Apr 2023 14:35:14 +0000
Message-ID: <E1pknBJ-001s7A-Cv@gemulon.postgresql.org> (raw)

Fix locale-dependent test case.

psql parses the interval argument of \watch with locale-dependent
strtod().  In commit 00beecfe8 I added a test case that exercises
a fractional interval, but I hard-coded 0.01 which doesn't work
in locales where the radix point isn't ".".  We don't want to
change this longstanding parsing behavior, so fix the test case
to generate a suitably locale-aware spelling.

Report and patch by Alexander Korotkov.

Discussion: https://postgr.es/m/CAPpHfdv+10Uk6FWjsh3+ju7kHYr76LaRXbYayXmrM7FBU-=Hgg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cd82e5c79d145dddd7a30ed35e4d3b83945b56f3

Modified Files
--------------
src/bin/psql/t/001_basic.pl | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)



Message-ID: <E1pknBJ-001s7A-Cv@gemulon.postgresql.org>
Permalink:  ../E1pknBJ-001s7A-Cv@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pknBJ-001s7A-Cv@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix locale-dependent test case.
  In-Reply-To: <E1pknBJ-001s7A-Cv@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox