From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Show more detail in heapam rmgr descriptions.
Date: Fri, 07 Apr 2023 23:09:15 +0000
Message-ID: <E1pkvCj-001w5Y-R3@gemulon.postgresql.org> (raw)
Show more detail in heapam rmgr descriptions.
Add helper functions that output arrays in a standard format, and use
the functions inside heapdesc routines. This allows tools like
pg_walinspect to show a detailed description of the page offset number
arrays for records like PRUNE and VACUUM (unless there was an FPI).
Also document the conventions that desc routines should follow. Only
the heapdesc routines follow the conventions for now, so they're just
guidelines for the time being.
Based on a suggestion from Andres Freund.
Author: Melanie Plageman <melanieplageman@gmail.com>
Reviewed-By: Peter Geoghegan <pg@bowt.ie>
Discussion: https://postgr.es/m/flat/20230109215842.fktuhesvayno6o4g%40awork3.anarazel.de
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/7d8219a444bd917d21234c97e2417a410f10ebd3
Modified Files
--------------
doc/src/sgml/pgwalinspect.sgml | 22 ++--
src/backend/access/rmgrdesc/Makefile | 1 +
src/backend/access/rmgrdesc/heapdesc.c | 155 ++++++++++++++++++++++-----
src/backend/access/rmgrdesc/meson.build | 1 +
src/backend/access/rmgrdesc/rmgrdesc_utils.c | 84 +++++++++++++++
src/bin/pg_waldump/Makefile | 2 +-
src/include/access/rmgrdesc_utils.h | 22 ++++
7 files changed, 247 insertions(+), 40 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: pg@bowt.ie, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Show more detail in heapam rmgr descriptions.
In-Reply-To: <E1pkvCj-001w5Y-R3@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox