pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Simplify version check for SKIP clause
Date: Sat, 08 Apr 2023 21:38:48 +0000
Message-ID: <E1plGGl-0026oj-NL@gemulon.postgresql.org> (raw)

Simplify version check for SKIP clause

Checking for the required versions of IO::Pty as well as IPC::Run
can be achieved with a single eval call, and by using the VERSION
function the comparison is guaranteed to follow the same rules as
calling 'use' on the module with a version.

Reported-by: Andrew Dunstan <andrew@dunslane.net>
Discussion: https://postgr.es/m/6d880ea2-f8ca-f458-4dcd-a7a3e6d6cd7c@dunslane.net

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6ff2e8cdd410f70057cfa6259ad395c1119aeb32

Modified Files
--------------
src/test/authentication/t/001_password.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



Message-ID: <E1plGGl-0026oj-NL@gemulon.postgresql.org>
Permalink:  ../E1plGGl-0026oj-NL@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1plGGl-0026oj-NL@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: dgustafsson@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Simplify version check for SKIP clause
  In-Reply-To: <E1plGGl-0026oj-NL@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox