pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve ereports for VACUUM's BUFFER_USAGE_LIMIT option
Date: Tue, 11 Apr 2023 07:37:11 +0000
Message-ID: <E1pm8Yw-002V3T-Kb@gemulon.postgresql.org> (raw)

Improve ereports for VACUUM's BUFFER_USAGE_LIMIT option

There's no need to check if opt->arg is NULL since defGetString() already
does that and raises an ERROR if it is.  Let's just remove that check.

Also, combine the two remaining ERRORs into a single check.  It seems
better to give an indication about what sort of values we're looking for
rather than just to state that the value given isn't valid.  Make
BUFFER_USAGE_LIMIT uppercase in this ERROR message too.  It's already
upper case in one other error message, so make that consistent.

Reported-by: Kyotaro Horiguchi
Discussion: https://postgr.es/m/20230411.102335.1643720544536884844.horikyota.ntt@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/68a2a437f46716efd54d177edf9dbcc9916c903b

Modified Files
--------------
src/backend/commands/vacuum.c        | 33 ++++++++-------------------------
src/test/regress/expected/vacuum.out |  6 +++---
2 files changed, 11 insertions(+), 28 deletions(-)



Message-ID: <E1pm8Yw-002V3T-Kb@gemulon.postgresql.org>
Permalink:  ../E1pm8Yw-002V3T-Kb@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pm8Yw-002V3T-Kb@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Improve ereports for VACUUM's BUFFER_USAGE_LIMIT option
  In-Reply-To: <E1pm8Yw-002V3T-Kb@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox