pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix xl_heap_lock WAL record field's data type.
Date: Tue, 11 Apr 2023 21:08:17 +0000
Message-ID: <E1pmLDs-002aoa-1c@gemulon.postgresql.org> (raw)

Fix xl_heap_lock WAL record field's data type.

Make xl_heap_lock's infobits_set field of type uint8, not int8.  Using
int8 isn't appropriate given that the field just holds status bits.
This fixes an oversight in commit 0ac5ad5134.

In passing rename the nearby TransactionId field to "xmax" to make
things consistency with related records, such as xl_heap_lock_updated.

Deliberately avoid a bump in XLOG_PAGE_MAGIC.  No backpatch, either.

Author: Peter Geoghegan <pg@bowt.ie>
Discussion: https://postgr.es/m/CAH2-WzkCd3kOS8b7Rfxw7Mh1_6jvX=Nzo-CWR1VBTiOtVZkWHA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e944063294fb9e85190f03948f5ce20331231e2f

Modified Files
--------------
src/backend/access/heap/heapam.c       | 6 +++---
src/backend/access/rmgrdesc/heapdesc.c | 4 ++--
src/include/access/heapam_xlog.h       | 6 +++---
3 files changed, 8 insertions(+), 8 deletions(-)



Message-ID: <E1pmLDs-002aoa-1c@gemulon.postgresql.org>
Permalink:  ../E1pmLDs-002aoa-1c@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pmLDs-002aoa-1c@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: pg@bowt.ie, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix xl_heap_lock WAL record field's data type.
  In-Reply-To: <E1pmLDs-002aoa-1c@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox