pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Skip the 004_io_direct.pl test if a pre-flight check fails.
Date: Thu, 13 Apr 2023 02:01:26 +0000
Message-ID: <E1pmmH7-002n2B-AY@gemulon.postgresql.org> (raw)

Skip the 004_io_direct.pl test if a pre-flight check fails.

The test previously had a list of OSes that direct I/O was expected to
work on.  That worked well enough for the systems in our build farm, but
didn't survive contact with the Debian build bots running on tmpfs via
overlayfs.  tmpfs does not support O_DIRECT, but we don't want to
exclude Linux generally.

The new approach is to try to create an empty file with O_DIRECT from
Perl first.  If that fails, we'll skip the test and report what the
error was.

Reported-by: Christoph Berg <myon@debian.org>
Reviewed-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Reviewed-by: Andrew Dunstan <andrew@dunslane.net>
Discussion: https://postgr.es/m/ZDYd4A78cT2ULxZZ%40msg.df7cb.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6ca8df2d61473327b0e90b9becfe109299f47b8a

Modified Files
--------------
src/test/modules/test_misc/t/004_io_direct.pl | 35 +++++++++++++++++++++------
1 file changed, 27 insertions(+), 8 deletions(-)



Message-ID: <E1pmmH7-002n2B-AY@gemulon.postgresql.org>
Permalink:  ../E1pmmH7-002n2B-AY@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pmmH7-002n2B-AY@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tmunro@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Skip the 004_io_direct.pl test if a pre-flight check fails.
  In-Reply-To: <E1pmmH7-002n2B-AY@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox