pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix incorrect partition pruning logic for boolean partitioned ta
Date: Fri, 14 Apr 2023 04:20:56 +0000
Message-ID: <E1pnAvf-002yCv-ND@gemulon.postgresql.org> (raw)

Fix incorrect partition pruning logic for boolean partitioned tables

The partition pruning logic assumed that "b IS NOT true" was exactly the
same as "b IS FALSE".  This is not the case when considering NULL values.
Fix this so we correctly include any partition which could hold NULL
values for the NOT case.

Additionally, this fixes a bug in the partition pruning code which handles
partitioned tables partitioned like ((NOT boolcol)).  This is a seemingly
unlikely schema design, and it was untested and also broken.

Here we add tests for the ((NOT boolcol)) case and insert some actual data
into those tables and verify we do get the correct rows back when running
queries.  I've also adjusted the existing boolpart tests to include some
data and verify we get the correct results too.

Both the bugs being fixed here could lead to incorrect query results with
fewer rows being returned than expected.  No additional rows could have
been returned accidentally.

In passing, remove needless ternary expression.  It's more simple just to
pass !is_not_clause to makeBoolConst().  It makes sense to do this so the
code is consistent with the bug fix in the "else if" condition just below.

David Kimura did submit a patch to fix the first of the issues here, but
that's not what's being committed here.

Reported-by: David Kimura
Reviewed-by: Richard Guo, David Kimura
Discussion: https://postgr.es/m/CAHnPFjQ5qxs6J_p+g8=ww7GQvfn71_JE+Tygj0S7RdRci1uwPw@mail.gmail.com
Backpatch-through: 11, all supported versions

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e0693faf797f997f45bee8e572e8b4288cc7eaeb

Modified Files
--------------
src/backend/partitioning/partprune.c          |  54 +++---
src/test/regress/expected/partition_prune.out | 227 ++++++++++++++++++++++++--
src/test/regress/sql/partition_prune.sql      |  38 ++++-
3 files changed, 288 insertions(+), 31 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1pnAvf-002yCv-ND@gemulon.postgresql.org>
Permalink:  ../E1pnAvf-002yCv-ND@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pnAvf-002yCv-ND@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix incorrect partition pruning logic for boolean partitioned ta
  In-Reply-To: <E1pnAvf-002yCv-ND@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox