pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Remove duplicate lines of code
6+ messages / 1 participants
[nested] [flat]

* pgsql: Remove duplicate lines of code
@ 2023-04-24 09:33  Daniel Gustafsson <dgustafsson@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Daniel Gustafsson @ 2023-04-24 09:33 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove duplicate lines of code

Commit 6df7a9698bb accidentally included two identical prototypes for
default_multirange_selectivi() and commit 086cf1458c6 added a break;
statement where one was already present, thus duplicating it.  While
there is no bug caused by this, fix by removing the duplicated lines
as they provide no value.

Backpatch the fix for duplicate prototypes to v14 and the duplicate
break statement fix to all supported branches to avoid backpatching
hazards due to the removal.

Reported-by: Anton Voloshin <a.voloshin@postgrespro.ru>
Discussion: https://postgr.es/m/0e69cb60-0176-f6d0-7e15-6478b7d85724@postgrespro.ru

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/69537f5d17eab2919c9d88880cb242de1e7a647d

Modified Files
--------------
src/backend/utils/adt/multirangetypes_selfuncs.c | 1 -
src/interfaces/ecpg/preproc/variable.c           | 1 -
2 files changed, 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Remove duplicate lines of code
@ 2023-04-24 09:34  Daniel Gustafsson <dgustafsson@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Daniel Gustafsson @ 2023-04-24 09:34 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove duplicate lines of code

Commit 6df7a9698bb accidentally included two identical prototypes for
default_multirange_selectivi() and commit 086cf1458c6 added a break;
statement where one was already present, thus duplicating it.  While
there is no bug caused by this, fix by removing the duplicated lines
as they provide no value.

Backpatch the fix for duplicate prototypes to v14 and the duplicate
break statement fix to all supported branches to avoid backpatching
hazards due to the removal.

Reported-by: Anton Voloshin <a.voloshin@postgrespro.ru>
Discussion: https://postgr.es/m/0e69cb60-0176-f6d0-7e15-6478b7d85724@postgrespro.ru

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a63b821c137524ad1ec699f20c0bf57987ffce82

Modified Files
--------------
src/backend/utils/adt/multirangetypes_selfuncs.c | 1 -
src/interfaces/ecpg/preproc/variable.c           | 1 -
2 files changed, 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Remove duplicate lines of code
@ 2023-04-24 09:35  Daniel Gustafsson <dgustafsson@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Daniel Gustafsson @ 2023-04-24 09:35 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove duplicate lines of code

Commit 6df7a9698bb accidentally included two identical prototypes for
default_multirange_selectivi() and commit 086cf1458c6 added a break;
statement where one was already present, thus duplicating it.  While
there is no bug caused by this, fix by removing the duplicated lines
as they provide no value.

Backpatch the fix for duplicate prototypes to v14 and the duplicate
break statement fix to all supported branches to avoid backpatching
hazards due to the removal.

Reported-by: Anton Voloshin <a.voloshin@postgrespro.ru>
Discussion: https://postgr.es/m/0e69cb60-0176-f6d0-7e15-6478b7d85724@postgrespro.ru

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/34e09e71aca51a9e722ff3ec819c0d92f4247bdd

Modified Files
--------------
src/backend/utils/adt/multirangetypes_selfuncs.c | 1 -
src/interfaces/ecpg/preproc/variable.c           | 1 -
2 files changed, 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Remove duplicate lines of code
@ 2023-04-24 09:35  Daniel Gustafsson <dgustafsson@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Daniel Gustafsson @ 2023-04-24 09:35 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove duplicate lines of code

Commit 6df7a9698bb accidentally included two identical prototypes for
default_multirange_selectivi() and commit 086cf1458c6 added a break;
statement where one was already present, thus duplicating it.  While
there is no bug caused by this, fix by removing the duplicated lines
as they provide no value.

Backpatch the fix for duplicate prototypes to v14 and the duplicate
break statement fix to all supported branches to avoid backpatching
hazards due to the removal.

Reported-by: Anton Voloshin <a.voloshin@postgrespro.ru>
Discussion: https://postgr.es/m/0e69cb60-0176-f6d0-7e15-6478b7d85724@postgrespro.ru

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/50b23e4374775749e35f84469a9cd080928ef333

Modified Files
--------------
src/interfaces/ecpg/preproc/variable.c | 1 -
1 file changed, 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Remove duplicate lines of code
@ 2023-04-24 09:35  Daniel Gustafsson <dgustafsson@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Daniel Gustafsson @ 2023-04-24 09:35 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove duplicate lines of code

Commit 6df7a9698bb accidentally included two identical prototypes for
default_multirange_selectivi() and commit 086cf1458c6 added a break;
statement where one was already present, thus duplicating it.  While
there is no bug caused by this, fix by removing the duplicated lines
as they provide no value.

Backpatch the fix for duplicate prototypes to v14 and the duplicate
break statement fix to all supported branches to avoid backpatching
hazards due to the removal.

Reported-by: Anton Voloshin <a.voloshin@postgrespro.ru>
Discussion: https://postgr.es/m/0e69cb60-0176-f6d0-7e15-6478b7d85724@postgrespro.ru

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/082e571c65036a21d5db6d6b9d2b159167b59916

Modified Files
--------------
src/interfaces/ecpg/preproc/variable.c | 1 -
1 file changed, 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Remove duplicate lines of code
@ 2023-04-24 09:35  Daniel Gustafsson <dgustafsson@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Daniel Gustafsson @ 2023-04-24 09:35 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove duplicate lines of code

Commit 6df7a9698bb accidentally included two identical prototypes for
default_multirange_selectivi() and commit 086cf1458c6 added a break;
statement where one was already present, thus duplicating it.  While
there is no bug caused by this, fix by removing the duplicated lines
as they provide no value.

Backpatch the fix for duplicate prototypes to v14 and the duplicate
break statement fix to all supported branches to avoid backpatching
hazards due to the removal.

Reported-by: Anton Voloshin <a.voloshin@postgrespro.ru>
Discussion: https://postgr.es/m/0e69cb60-0176-f6d0-7e15-6478b7d85724@postgrespro.ru

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/082b59335dbba2da64d77d4f55c8e2559fe548e2

Modified Files
--------------
src/interfaces/ecpg/preproc/variable.c | 1 -
1 file changed, 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2023-04-24 09:35 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-04-24 09:33 pgsql: Remove duplicate lines of code Daniel Gustafsson <dgustafsson@postgresql.org>
2023-04-24 09:34 pgsql: Remove duplicate lines of code Daniel Gustafsson <dgustafsson@postgresql.org>
2023-04-24 09:35 pgsql: Remove duplicate lines of code Daniel Gustafsson <dgustafsson@postgresql.org>
2023-04-24 09:35 pgsql: Remove duplicate lines of code Daniel Gustafsson <dgustafsson@postgresql.org>
2023-04-24 09:35 pgsql: Remove duplicate lines of code Daniel Gustafsson <dgustafsson@postgresql.org>
2023-04-24 09:35 pgsql: Remove duplicate lines of code Daniel Gustafsson <dgustafsson@postgresql.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox