pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove duplicate lines of code
Date: Mon, 24 Apr 2023 09:35:01 +0000
Message-ID: <E1pqsb6-004efr-62@gemulon.postgresql.org> (raw)

Remove duplicate lines of code

Commit 6df7a9698bb accidentally included two identical prototypes for
default_multirange_selectivi() and commit 086cf1458c6 added a break;
statement where one was already present, thus duplicating it.  While
there is no bug caused by this, fix by removing the duplicated lines
as they provide no value.

Backpatch the fix for duplicate prototypes to v14 and the duplicate
break statement fix to all supported branches to avoid backpatching
hazards due to the removal.

Reported-by: Anton Voloshin <a.voloshin@postgrespro.ru>
Discussion: https://postgr.es/m/0e69cb60-0176-f6d0-7e15-6478b7d85724@postgrespro.ru

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/34e09e71aca51a9e722ff3ec819c0d92f4247bdd

Modified Files
--------------
src/backend/utils/adt/multirangetypes_selfuncs.c | 1 -
src/interfaces/ecpg/preproc/variable.c           | 1 -
2 files changed, 2 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1pqsb6-004efr-62@gemulon.postgresql.org>
Permalink:  ../E1pqsb6-004efr-62@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pqsb6-004efr-62@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: dgustafsson@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove duplicate lines of code
  In-Reply-To: <E1pqsb6-004efr-62@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox