pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Rename ExecAggTransReparent, and improve its documentation.
Date: Mon, 24 Apr 2023 17:01:44 +0000
Message-ID: <E1pqzZO-004hrE-UZ@gemulon.postgresql.org> (raw)

Rename ExecAggTransReparent, and improve its documentation.

The name of this function suggests that it ought to reparent R/W
expanded objects to be children of the persistent aggcontext, instead
of copying them.  In fact it does no such thing, and if you try to
make it do so you will see multiple regression failures.  Rename it
to the less-misleading ExecAggCopyTransValue, and add commentary
about why that attractive-sounding optimization won't work.  Also
adjust comments at call sites, some of which were describing logic
that has since been moved into ExecAggCopyTransValue.

Discussion: https://postgr.es/m/3004282.1681930251@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fce3b26e97ca98de054734e2af7d9125661a9b3f

Modified Files
--------------
src/backend/executor/execExprInterp.c | 49 +++++++++++++++++++++++++----------
src/backend/executor/nodeAgg.c        | 14 +++++-----
src/backend/executor/nodeWindowAgg.c  |  6 +++--
src/backend/jit/llvm/llvmjit_expr.c   |  2 +-
src/backend/jit/llvm/llvmjit_types.c  |  2 +-
src/include/executor/execExpr.h       |  6 ++---
6 files changed, 51 insertions(+), 28 deletions(-)



Message-ID: <E1pqzZO-004hrE-UZ@gemulon.postgresql.org>
Permalink:  ../E1pqzZO-004hrE-UZ@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pqzZO-004hrE-UZ@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Rename ExecAggTransReparent, and improve its documentation.
  In-Reply-To: <E1pqzZO-004hrE-UZ@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox