From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix buffer refcount leak with FDW bulk inserts
Date: Tue, 25 Apr 2023 00:43:14 +0000
Message-ID: <E1pr6m1-004l4z-95@gemulon.postgresql.org> (raw)
Fix buffer refcount leak with FDW bulk inserts
The leak would show up when using batch inserts with foreign tables
included in a partition tree, as the slots used in the batch were not
reset once processed. In order to fix this problem, some
ExecClearTuple() are added to clean up the slots used once a batch is
filled and processed, mapping with the number of slots currently in use
as tracked by the counter ri_NumSlots.
This buffer refcount leak has been introduced in b676ac4 with the
addition of the executor facility to improve bulk inserts for FDWs, so
backpatch down to 14.
Alexander has provided the patch (slightly modified by me). The test
for postgres_fdw comes from me, based on the test case that the author
has sent in the report.
Author: Alexander Pyhalov
Discussion: https://postgr.es/m/b035780a740efd38dc30790c76927255@postgrespro.ru
Backpatch-through: 14
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/aa6177c882d4cd11559d0a10b73e6cd1d8c18fb1
Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out | 22 ++++++++++++++++++++++
contrib/postgres_fdw/sql/postgres_fdw.sql | 18 ++++++++++++++++++
src/backend/executor/nodeModifyTable.c | 10 ++++++++--
3 files changed, 48 insertions(+), 2 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix buffer refcount leak with FDW bulk inserts
In-Reply-To: <E1pr6m1-004l4z-95@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox