pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix stop condition for dumping GRANT commands
Date: Wed, 26 Apr 2023 12:27:51 +0000
Message-ID: <E1preFS-005033-8X@gemulon.postgresql.org> (raw)

Fix stop condition for dumping GRANT commands

Commit ce6b672e44 changed dumping GRANT commands to ensure that
grantors already have an ADMIN OPTION on the role for which it
is granting permissions. Looping over the grants per role has a
stop condition on dumping the grant statements, but accidentally
missed updating the variable for the conditional check.

Author: Andreas Scherbaum <ads@pgug.de>
Co-authored-by: Artur Zakirov <zaartur@gmail.com>
Discussion: https://postgr.es/m/de44299d-cd31-b41f-2c2a-161fa5e586a5@pgug.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7b7fa85130330128b404eddebd4f33c6739454b0

Modified Files
--------------
src/bin/pg_dump/pg_dumpall.c | 1 +
1 file changed, 1 insertion(+)



Message-ID: <E1preFS-005033-8X@gemulon.postgresql.org>
Permalink:  ../E1preFS-005033-8X@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1preFS-005033-8X@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: dgustafsson@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix stop condition for dumping GRANT commands
  In-Reply-To: <E1preFS-005033-8X@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox