pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert "Move PartitionPruneInfo out of plan nodes into PlannedSt
Date: Thu, 04 May 2023 10:10:48 +0000
Message-ID: <E1puVvD-000QKJ-JY@gemulon.postgresql.org> (raw)

Revert "Move PartitionPruneInfo out of plan nodes into PlannedStmt"

This reverts commit ec386948948c and its fixup 589bb816499e.

This change was intended to support query planning avoiding acquisition
of locks on partitions that were going to be pruned; however, the
overall project took a different direction at [1] and this bit is no
longer needed.  Put things back the way they were as agreed in [2], to
avoid unnecessary complexity.

Discussion: [1] https://postgr.es/m/4191508.1674157166@sss.pgh.pa.us
Discussion: [2] https://postgr.es/m/20230502175409.kcoirxczpdha26wt@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5472743d9e8583638a897b47558066167cc14583

Modified Files
--------------
src/backend/executor/execMain.c         |  1 -
src/backend/executor/execParallel.c     |  1 -
src/backend/executor/execPartition.c    | 18 +------
src/backend/executor/execUtils.c        |  1 -
src/backend/executor/nodeAppend.c       |  5 +-
src/backend/executor/nodeMergeAppend.c  |  5 +-
src/backend/optimizer/plan/createplan.c | 24 +++++----
src/backend/optimizer/plan/planner.c    |  1 -
src/backend/optimizer/plan/setrefs.c    | 88 +++++++++++----------------------
src/backend/partitioning/partprune.c    | 19 +++----
src/include/catalog/catversion.h        |  2 +-
src/include/executor/execPartition.h    |  4 +-
src/include/nodes/execnodes.h           |  1 -
src/include/nodes/pathnodes.h           |  6 ---
src/include/nodes/plannodes.h           | 14 ++----
src/include/partitioning/partprune.h    |  8 +--
16 files changed, 63 insertions(+), 135 deletions(-)



Message-ID: <E1puVvD-000QKJ-JY@gemulon.postgresql.org>
Permalink:  ../E1puVvD-000QKJ-JY@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1puVvD-000QKJ-JY@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Revert "Move PartitionPruneInfo out of plan nodes into PlannedSt
  In-Reply-To: <E1puVvD-000QKJ-JY@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox