pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Undo faulty attempt at not relying on RINFO_IS_PUSHED_DOWN.
Date: Thu, 11 May 2023 17:45:16 +0000
Message-ID: <E1pxALr-001dyg-J9@gemulon.postgresql.org> (raw)

Undo faulty attempt at not relying on RINFO_IS_PUSHED_DOWN.

I've had a bee in my bonnet for some time about getting rid of
RestrictInfo.is_pushed_down, because it's squishily defined and
requires not-inexpensive extra tests to use (cf RINFO_IS_PUSHED_DOWN).
In commit 2489d76c4, I tried to make remove_rel_from_query() not
depend on that macro; but the replacement test is buggy,
as exposed by a report from Rushabh Lathia and Robert Haas.
That change was pretty incidental to the main goal of 2489d76c4,
so let's just revert it for now.  (Getting rid of is_pushed_down
is still far away, anyway.)

Discussion: https://postgr.es/m/CA+TgmoYco=hmg+iX1CW9Y1_CzNoSL81J03wUG-d2_3=rue+L2A@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c8b881d21fd8e0214bc43280d6231cc2c6ef55ef

Modified Files
--------------
src/backend/optimizer/plan/analyzejoins.c |  7 +------
src/test/regress/expected/join.out        | 16 ++++++++++++++++
src/test/regress/sql/join.sql             |  6 ++++++
3 files changed, 23 insertions(+), 6 deletions(-)



Message-ID: <E1pxALr-001dyg-J9@gemulon.postgresql.org>
Permalink:  ../E1pxALr-001dyg-J9@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pxALr-001dyg-J9@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Undo faulty attempt at not relying on RINFO_IS_PUSHED_DOWN.
  In-Reply-To: <E1pxALr-001dyg-J9@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox