pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Tighten usage of PSQL_WATCH_PAGER.
Date: Fri, 12 May 2023 20:11:24 +0000
Message-ID: <E1pxZ6p-001pGJ-L4@gemulon.postgresql.org> (raw)

Tighten usage of PSQL_WATCH_PAGER.

Don't use PSQL_WATCH_PAGER when stdin/stdout are not a terminal.
This corresponds to the restrictions on when other commands will
use [PSQL_]PAGER.  There isn't a lot of sense in trying to use a
pager in non-interactive cases, and doing so allows an environment
setting to break our tests.

Also, ignore PSQL_WATCH_PAGER if it is set but empty or all-blank,
for the same reasons we ignore such settings of [PSQL_]PAGER (see
commit 18f8f784c).

No documentation change is really needed, since there is nothing
suggesting that these constraints on [PSQL_]PAGER didn't already
apply to PSQL_WATCH_PAGER too.  But I rearranged the text
a little to make it read more naturally (IMHO anyway).

Per report from Pavel Stehule.  Back-patch to v15 where
PSQL_WATCH_PAGER was introduced.

Discussion: https://postgr.es/m/CAFj8pRDTwFzmEWdA-gdAcUh0ZnxUioSfTMre71WyB_wNJy-8gw@mail.gmail.com

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/bc478a0a85bc8660bfa251866f85c673e4be84ac

Modified Files
--------------
doc/src/sgml/ref/psql-ref.sgml | 31 ++++++++++++++++---------------
src/bin/psql/command.c         | 14 ++++++++++----
2 files changed, 26 insertions(+), 19 deletions(-)



view thread (2+ messages)

Message-ID: <E1pxZ6p-001pGJ-L4@gemulon.postgresql.org>
Permalink:  ../E1pxZ6p-001pGJ-L4@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pxZ6p-001pGJ-L4@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Tighten usage of PSQL_WATCH_PAGER.
  In-Reply-To: <E1pxZ6p-001pGJ-L4@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox