pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix wal_writer_flush_after initializer value.
Date: Sun, 14 May 2023 23:22:20 +0000
Message-ID: <E1pyL2i-002B3F-6k@gemulon.postgresql.org> (raw)

Fix wal_writer_flush_after initializer value.

Commit a73952b7956 (new in 16) required default values in guc_table.c
and C variable initializers to match.  This one only matched when
XLOG_BLCKSZ == 8kB.  Fix by using the same expression in both places
with a new DEFAULT_XXX macro, as done for other GUCs.

Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/CA+hUKGLNmLV=VrT==5MqnbARgx2ifRSFtdd8ofdfrdSLL3yv5A@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/63932a6d38e5dfa6df2a51a04b7314ec1e4d3de7

Modified Files
--------------
src/backend/postmaster/walwriter.c  | 2 +-
src/backend/utils/misc/guc_tables.c | 2 +-
src/include/postmaster/walwriter.h  | 2 ++
3 files changed, 4 insertions(+), 2 deletions(-)



Message-ID: <E1pyL2i-002B3F-6k@gemulon.postgresql.org>
Permalink:  ../E1pyL2i-002B3F-6k@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pyL2i-002B3F-6k@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tmunro@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix wal_writer_flush_after initializer value.
  In-Reply-To: <E1pyL2i-002B3F-6k@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox