pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix incorrect TAP test ordering
Date: Mon, 15 May 2023 06:03:18 +0000
Message-ID: <E1pyRIk-002Dgn-Ek@gemulon.postgresql.org> (raw)

Fix incorrect TAP test ordering

Using a test function before a possible skip_all is incorrect.  If the
skip_all is called, the test output will become incorrect and the test
file will fail.

a4f23f9b3c introduced a new test before skip_all.  After discussion,
this doesn't really need to be a test.  Instead, we just bail out if
the condition is not satisfied.

Discussion: https://www.postgresql.org/message-id/af5567a1-aea6-fbdb-7e4b-d1e23a43c43b@enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/92155e15d3cfe97758552484acb1583aaf71cda6

Modified Files
--------------
src/bin/pg_amcheck/t/004_verify_heapam.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



Message-ID: <E1pyRIk-002Dgn-Ek@gemulon.postgresql.org>
Permalink:  ../E1pyRIk-002Dgn-Ek@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pyRIk-002Dgn-Ek@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix incorrect TAP test ordering
  In-Reply-To: <E1pyRIk-002Dgn-Ek@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox