pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Advance input pointer when LZ4 compressing data
Date: Wed, 17 May 2023 15:00:59 +0000
Message-ID: <E1pzIeC-000Lpb-8L@gemulon.postgresql.org> (raw)

Advance input pointer when LZ4 compressing data

LZ4File_write() did not advance the input pointer on subsequent invocations of
LZ4F_compressUpdate(). As a result the generated compressed output would be a
compressed version of the same input chunk.

Tests failed to catch this error because the data would comfortably fit
within the default buffer size, as a single chunk. Tests have been added
to provide adequate coverage of multi-chunk compression.

WriteDataToArchiveLZ4() which is also using LZ4F_compressUpdate() did
not suffer from this omission.

Author: Georgios Kokolatos <gkokolatos@pm.me>
Reported-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/ZFhCyn4Gm2eu60rB%40paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1a05c1d252993b0a59c58a6daf91a2df9333044f

Modified Files
--------------
src/bin/pg_dump/compress_io.h    |  8 ++++++-
src/bin/pg_dump/compress_lz4.c   |  2 ++
src/bin/pg_dump/t/002_pg_dump.pl | 46 ++++++++++++++++++++++++++++++++++++++++
3 files changed, 55 insertions(+), 1 deletion(-)



Message-ID: <E1pzIeC-000Lpb-8L@gemulon.postgresql.org>
Permalink:  ../E1pzIeC-000Lpb-8L@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pzIeC-000Lpb-8L@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tomas.vondra@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Advance input pointer when LZ4 compressing data
  In-Reply-To: <E1pzIeC-000Lpb-8L@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox