pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Convert nullingrels match checks from Asserts to test-and-elog.
Date: Wed, 17 May 2023 15:14:16 +0000
Message-ID: <E1pzIr2-000Luw-T1@gemulon.postgresql.org> (raw)

Convert nullingrels match checks from Asserts to test-and-elog.

It seems like the code that these checks are backstopping may have
a few bugs left in it.  Use a test-and-elog so that the tests are
performed even in non-assert builds, and so that we get something
more informative than "server closed the connection" on failure.

Committed separately with the idea that eventually we'll revert
this.  It might be awhile though.

Discussion: https://postgr.es/m/3014965.1684293045@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/867be9c0738bef591544d39985f886b7d8e99bf0

Modified Files
--------------
src/backend/optimizer/plan/setrefs.c | 34 +++++++++++++++++++++-------------
1 file changed, 21 insertions(+), 13 deletions(-)



Message-ID: <E1pzIr2-000Luw-T1@gemulon.postgresql.org>
Permalink:  ../E1pzIr2-000Luw-T1@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pzIr2-000Luw-T1@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Convert nullingrels match checks from Asserts to test-and-elog.
  In-Reply-To: <E1pzIr2-000Luw-T1@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox