pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Avoid naming conflict between transactions.sql and namespace.sql
Date: Fri, 19 May 2023 14:57:58 +0000
Message-ID: <E1q01YN-000h28-5s@gemulon.postgresql.org> (raw)

Avoid naming conflict between transactions.sql and namespace.sql.

Commits 681d9e462 et al added a test case in namespace.sql that
implicitly relied on there not being a table "public.abc".
However, the concurrently-run transactions.sql test creates precisely
such a table, so with the right timing you'd get a failure.
Creating a table named as generically as "abc" in a common schema
seems like bad practice, so fix this by changing the name of
transactions.sql's table.  (Compare 2cf8c7aa4.)

Marina Polyakova

Discussion: https://postgr.es/m/80d0201636665d82185942e7112257b4@postgrespro.ru

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4cdda71d4dc33dd35e8cdbca5dd2e2a7a1234092

Modified Files
--------------
src/test/regress/expected/transactions.out | 76 +++++++++++++++---------------
src/test/regress/sql/transactions.sql      | 64 ++++++++++++-------------
2 files changed, 70 insertions(+), 70 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1q01YN-000h28-5s@gemulon.postgresql.org>
Permalink:  ../E1q01YN-000h28-5s@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1q01YN-000h28-5s@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Avoid naming conflict between transactions.sql and namespace.sql
  In-Reply-To: <E1q01YN-000h28-5s@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox