pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Avoid naming conflict between transactions.sql and namespace.sql
6+ messages / 1 participants
[nested] [flat]

* pgsql: Avoid naming conflict between transactions.sql and namespace.sql
@ 2023-05-19 14:57  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2023-05-19 14:57 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Avoid naming conflict between transactions.sql and namespace.sql.

Commits 681d9e462 et al added a test case in namespace.sql that
implicitly relied on there not being a table "public.abc".
However, the concurrently-run transactions.sql test creates precisely
such a table, so with the right timing you'd get a failure.
Creating a table named as generically as "abc" in a common schema
seems like bad practice, so fix this by changing the name of
transactions.sql's table.  (Compare 2cf8c7aa4.)

Marina Polyakova

Discussion: https://postgr.es/m/80d0201636665d82185942e7112257b4@postgrespro.ru

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/6f1cf2efbd0199c58db9f256ade48f42f56cab49

Modified Files
--------------
src/test/regress/expected/transactions.out | 18 +++++++++---------
src/test/regress/sql/transactions.sql      | 18 +++++++++---------
2 files changed, 18 insertions(+), 18 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Avoid naming conflict between transactions.sql and namespace.sql
@ 2023-05-19 14:57  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2023-05-19 14:57 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Avoid naming conflict between transactions.sql and namespace.sql.

Commits 681d9e462 et al added a test case in namespace.sql that
implicitly relied on there not being a table "public.abc".
However, the concurrently-run transactions.sql test creates precisely
such a table, so with the right timing you'd get a failure.
Creating a table named as generically as "abc" in a common schema
seems like bad practice, so fix this by changing the name of
transactions.sql's table.  (Compare 2cf8c7aa4.)

Marina Polyakova

Discussion: https://postgr.es/m/80d0201636665d82185942e7112257b4@postgrespro.ru

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/cf9de891ba388829c4a777f48c22fbf93a24d3ea

Modified Files
--------------
src/test/regress/expected/transactions.out | 76 +++++++++++++++---------------
src/test/regress/sql/transactions.sql      | 64 ++++++++++++-------------
2 files changed, 70 insertions(+), 70 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Avoid naming conflict between transactions.sql and namespace.sql
@ 2023-05-19 14:57  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2023-05-19 14:57 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Avoid naming conflict between transactions.sql and namespace.sql.

Commits 681d9e462 et al added a test case in namespace.sql that
implicitly relied on there not being a table "public.abc".
However, the concurrently-run transactions.sql test creates precisely
such a table, so with the right timing you'd get a failure.
Creating a table named as generically as "abc" in a common schema
seems like bad practice, so fix this by changing the name of
transactions.sql's table.  (Compare 2cf8c7aa4.)

Marina Polyakova

Discussion: https://postgr.es/m/80d0201636665d82185942e7112257b4@postgrespro.ru

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4cdda71d4dc33dd35e8cdbca5dd2e2a7a1234092

Modified Files
--------------
src/test/regress/expected/transactions.out | 76 +++++++++++++++---------------
src/test/regress/sql/transactions.sql      | 64 ++++++++++++-------------
2 files changed, 70 insertions(+), 70 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Avoid naming conflict between transactions.sql and namespace.sql
@ 2023-05-19 14:57  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2023-05-19 14:57 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Avoid naming conflict between transactions.sql and namespace.sql.

Commits 681d9e462 et al added a test case in namespace.sql that
implicitly relied on there not being a table "public.abc".
However, the concurrently-run transactions.sql test creates precisely
such a table, so with the right timing you'd get a failure.
Creating a table named as generically as "abc" in a common schema
seems like bad practice, so fix this by changing the name of
transactions.sql's table.  (Compare 2cf8c7aa4.)

Marina Polyakova

Discussion: https://postgr.es/m/80d0201636665d82185942e7112257b4@postgrespro.ru

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b973f93b6c540f65c960bfb19af55f3d4afe4b72

Modified Files
--------------
src/test/regress/expected/transactions.out | 76 +++++++++++++++---------------
src/test/regress/sql/transactions.sql      | 64 ++++++++++++-------------
2 files changed, 70 insertions(+), 70 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Avoid naming conflict between transactions.sql and namespace.sql
@ 2023-05-19 14:57  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2023-05-19 14:57 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Avoid naming conflict between transactions.sql and namespace.sql.

Commits 681d9e462 et al added a test case in namespace.sql that
implicitly relied on there not being a table "public.abc".
However, the concurrently-run transactions.sql test creates precisely
such a table, so with the right timing you'd get a failure.
Creating a table named as generically as "abc" in a common schema
seems like bad practice, so fix this by changing the name of
transactions.sql's table.  (Compare 2cf8c7aa4.)

Marina Polyakova

Discussion: https://postgr.es/m/80d0201636665d82185942e7112257b4@postgrespro.ru

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/89f5eb26f6b9b2739aacf53676bfa0eee7be421a

Modified Files
--------------
src/test/regress/expected/transactions.out | 76 +++++++++++++++---------------
src/test/regress/sql/transactions.sql      | 64 ++++++++++++-------------
2 files changed, 70 insertions(+), 70 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Avoid naming conflict between transactions.sql and namespace.sql
@ 2023-05-19 14:57  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2023-05-19 14:57 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Avoid naming conflict between transactions.sql and namespace.sql.

Commits 681d9e462 et al added a test case in namespace.sql that
implicitly relied on there not being a table "public.abc".
However, the concurrently-run transactions.sql test creates precisely
such a table, so with the right timing you'd get a failure.
Creating a table named as generically as "abc" in a common schema
seems like bad practice, so fix this by changing the name of
transactions.sql's table.  (Compare 2cf8c7aa4.)

Marina Polyakova

Discussion: https://postgr.es/m/80d0201636665d82185942e7112257b4@postgrespro.ru

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7d3c0b1f8f511be49062a3d3e47f427d076bd35e

Modified Files
--------------
src/test/regress/expected/transactions.out | 76 +++++++++++++++---------------
src/test/regress/sql/transactions.sql      | 64 ++++++++++++-------------
2 files changed, 70 insertions(+), 70 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2023-05-19 14:57 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-05-19 14:57 pgsql: Avoid naming conflict between transactions.sql and namespace.sql Tom Lane <tgl@sss.pgh.pa.us>
2023-05-19 14:57 pgsql: Avoid naming conflict between transactions.sql and namespace.sql Tom Lane <tgl@sss.pgh.pa.us>
2023-05-19 14:57 pgsql: Avoid naming conflict between transactions.sql and namespace.sql Tom Lane <tgl@sss.pgh.pa.us>
2023-05-19 14:57 pgsql: Avoid naming conflict between transactions.sql and namespace.sql Tom Lane <tgl@sss.pgh.pa.us>
2023-05-19 14:57 pgsql: Avoid naming conflict between transactions.sql and namespace.sql Tom Lane <tgl@sss.pgh.pa.us>
2023-05-19 14:57 pgsql: Avoid naming conflict between transactions.sql and namespace.sql Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox