From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove over-eager assertion in ExtendBufferedRelTo()
Date: Sun, 21 May 2023 17:14:01 +0000
Message-ID: <E1q0md8-0012gq-3x@gemulon.postgresql.org> (raw)
Remove over-eager assertion in ExtendBufferedRelTo()
The assertion checked that the size of the relation is not "too large" - but
the code is explicitly dealing with the possibility of another backend
extending the relation concurrently. In that case the new relation size could
be bigger than what the current backend needs, wrongly triggering an assertion
failure.
Unfortunately it is hard to write a reliable and affordable regression tests
for this, as a lot of concurrency is needed to encounter the bug.
Introduced in 31966b151e6a.
Reported-by: Melanie Plageman <melanieplageman@gmail.com>
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/eabb22525efc40ce0d83580584094a0248ac0682
Modified Files
--------------
src/backend/storage/buffer/bufmgr.c | 1 -
1 file changed, 1 deletion(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove over-eager assertion in ExtendBufferedRelTo()
In-Reply-To: <E1q0md8-0012gq-3x@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox