pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix misuse of pg_log_info() for details/hints.
Date: Sun, 04 Jun 2023 17:06:04 +0000
Message-ID: <E1q5rB5-000AZH-Cw@gemulon.postgresql.org> (raw)

Fix misuse of pg_log_info() for details/hints.

Two places in pg_dump_sort.c were using pg_log_info() to add
more details to a message printed with pg_log_warning().
This is bad, because at default verbosity level we would
print the warning line but not the details.  One should use
pg_log_warning_detail() or pg_log_warning_hint() instead.
Commit 9a374b77f got rid of most such abuses, but unaccountably
missed these.

Noted while studying a bug report from Sami Imseih.
Back-patch to v15 where 9a374b77f came in.  (Prior versions
don't have the missing-details misbehavior, for reasons
I didn't bother to track down.)

Discussion: https://postgr.es/m/2C1933AB-C2F8-499B-9D18-4AC1882256A0@amazon.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b3f32a6c312c476beecb7864450f4f6c448cd1bc

Modified Files
--------------
src/bin/pg_dump/pg_dump_sort.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1q5rB5-000AZH-Cw@gemulon.postgresql.org>
Permalink:  ../E1q5rB5-000AZH-Cw@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1q5rB5-000AZH-Cw@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix misuse of pg_log_info() for details/hints.
  In-Reply-To: <E1q5rB5-000AZH-Cw@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox