pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix misuse of pg_log_info() for details/hints. 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix misuse of pg_log_info() for details/hints. @ 2023-06-04 17:06 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2023-06-04 17:06 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix misuse of pg_log_info() for details/hints. Two places in pg_dump_sort.c were using pg_log_info() to add more details to a message printed with pg_log_warning(). This is bad, because at default verbosity level we would print the warning line but not the details. One should use pg_log_warning_detail() or pg_log_warning_hint() instead. Commit 9a374b77f got rid of most such abuses, but unaccountably missed these. Noted while studying a bug report from Sami Imseih. Back-patch to v15 where 9a374b77f came in. (Prior versions don't have the missing-details misbehavior, for reasons I didn't bother to track down.) Discussion: https://postgr.es/m/2C1933AB-C2F8-499B-9D18-4AC1882256A0@amazon.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/b3f32a6c312c476beecb7864450f4f6c448cd1bc Modified Files -------------- src/bin/pg_dump/pg_dump_sort.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix misuse of pg_log_info() for details/hints. @ 2023-06-04 17:06 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2023-06-04 17:06 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix misuse of pg_log_info() for details/hints. Two places in pg_dump_sort.c were using pg_log_info() to add more details to a message printed with pg_log_warning(). This is bad, because at default verbosity level we would print the warning line but not the details. One should use pg_log_warning_detail() or pg_log_warning_hint() instead. Commit 9a374b77f got rid of most such abuses, but unaccountably missed these. Noted while studying a bug report from Sami Imseih. Back-patch to v15 where 9a374b77f came in. (Prior versions don't have the missing-details misbehavior, for reasons I didn't bother to track down.) Discussion: https://postgr.es/m/2C1933AB-C2F8-499B-9D18-4AC1882256A0@amazon.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/751ba1a7c168b28a3cc43032e9a1cc996e004054 Modified Files -------------- src/bin/pg_dump/pg_dump_sort.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2023-06-04 17:06 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-06-04 17:06 pgsql: Fix misuse of pg_log_info() for details/hints. Tom Lane <tgl@sss.pgh.pa.us> 2023-06-04 17:06 pgsql: Fix misuse of pg_log_info() for details/hints. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox