pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix pg_dump's failure to honor dependencies of SQL functions.
Date: Sun, 04 Jun 2023 17:06:04 +0000
Message-ID: <E1q5rB5-000AZR-FX@gemulon.postgresql.org> (raw)

Fix pg_dump's failure to honor dependencies of SQL functions.

A new-style SQL function can contain a parse-time dependency
on a unique index, much as views and matviews can (such cases
arise from GROUP BY and ON CONFLICT clauses, for example).
To dump and restore such a function successfully, pg_dump must
postpone the function until after the unique index is created,
which will happen in the post-data part of the dump.  Therefore
we have to remove the normal constraint that functions are
dumped in pre-data.  Add code similar to the existing logic
that handles this for matviews.  I added test cases for both
as well, since code coverage tests showed that we weren't
testing the matview logic.

Per report from Sami Imseih.  Back-patch to v14 where
new-style SQL functions came in.

Discussion: https://postgr.es/m/2C1933AB-C2F8-499B-9D18-4AC1882256A0@amazon.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d6f549d7a6275e16668faf8cddc95d6759506108

Modified Files
--------------
src/bin/pg_dump/pg_dump.c        |  5 ++++-
src/bin/pg_dump/pg_dump.h        |  1 +
src/bin/pg_dump/pg_dump_sort.c   | 44 ++++++++++++++++++++++++++++++++++++++++
src/bin/pg_dump/t/002_pg_dump.pl | 40 ++++++++++++++++++++++++++++++++++++
4 files changed, 89 insertions(+), 1 deletion(-)



view thread (3+ messages)  latest in thread

Message-ID: <E1q5rB5-000AZR-FX@gemulon.postgresql.org>
Permalink:  ../E1q5rB5-000AZR-FX@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1q5rB5-000AZR-FX@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix pg_dump's failure to honor dependencies of SQL functions.
  In-Reply-To: <E1q5rB5-000AZR-FX@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox