pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Reload configuration more frequently in apply worker.
Date: Wed, 07 Jun 2023 04:02:54 +0000
Message-ID: <E1q6kNp-000Y4k-Hr@gemulon.postgresql.org> (raw)

Reload configuration more frequently in apply worker.

The apply worker was not reloading the configuration while processing
messages if there is a continuous flow of messages from upstream. It was
also not reloading the configuration if there is a change in the
configuration after it has waited for the message and before receiving the
new replication message. This can lead to failure in tests because we
expect that after reload, the behavior of apply worker to respect the
changed GUCs.

We found this while analyzing a rare buildfarm failure.

Author: Hou Zhijie
Reviewed-by: Amit Kapila
Discussion: https://postgr.es/m/OS0PR01MB5716AF9079CC0755CD015322947E9@OS0PR01MB5716.jpnprd01.prod.outlook.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d64e6468f489effec356ce3501c0f226ac1cfcc0

Modified Files
--------------
src/backend/replication/logical/worker.c | 6 ++++++
1 file changed, 6 insertions(+)



Message-ID: <E1q6kNp-000Y4k-Hr@gemulon.postgresql.org>
Permalink:  ../E1q6kNp-000Y4k-Hr@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1q6kNp-000Y4k-Hr@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: akapila@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Reload configuration more frequently in apply worker.
  In-Reply-To: <E1q6kNp-000Y4k-Hr@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox