pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove read-only server settings lc_collate and lc_ctype
Date: Wed, 07 Jun 2023 14:58:28 +0000
Message-ID: <E1q6ucG-000cMC-3y@gemulon.postgresql.org> (raw)

Remove read-only server settings lc_collate and lc_ctype

The GUC settings lc_collate and lc_ctype are from a time when those
locale settings were cluster-global.  When those locale settings were
made per-database (PG 8.4), the settings were kept as read-only.  As
of PG 15, you can use ICU as the per-database locale provider, so
examining these settings is already less meaningful and possibly
confusing, since you need to look into pg_database to find out what is
really happening, and they would likely become fully obsolete in the
future anyway.

Reviewed-by: Jeff Davis <pgsql@j-davis.com>
Discussion: https://www.postgresql.org/message-id/696054d1-bc88-b6ab-129a-18b8bce6a6f0@enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b0f6c437160db640d4ea3e49398ebc3ba39d1982

Modified Files
--------------
contrib/citext/expected/citext_utf8.out            |  4 +--
contrib/citext/expected/citext_utf8_1.out          |  4 +--
contrib/citext/sql/citext_utf8.sql                 |  4 +--
doc/src/sgml/config.sgml                           | 32 ----------------------
src/backend/utils/init/postinit.c                  |  4 ---
src/backend/utils/misc/guc_tables.c                | 26 ------------------
src/test/regress/expected/collate.icu.utf8.out     |  4 +--
src/test/regress/expected/collate.linux.utf8.out   |  6 ++--
.../regress/expected/collate.windows.win1252.out   |  6 ++--
src/test/regress/sql/collate.icu.utf8.sql          |  4 +--
src/test/regress/sql/collate.linux.utf8.sql        |  6 ++--
src/test/regress/sql/collate.windows.win1252.sql   |  6 ++--
12 files changed, 22 insertions(+), 84 deletions(-)



Message-ID: <E1q6ucG-000cMC-3y@gemulon.postgresql.org>
Permalink:  ../E1q6ucG-000cMC-3y@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1q6ucG-000cMC-3y@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove read-only server settings lc_collate and lc_ctype
  In-Reply-To: <E1q6ucG-000cMC-3y@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox