pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Don't use _BitScanForward64/_BitScanReverse64 on 32-bit MSVC bui
Date: Wed, 07 Jun 2023 22:11:56 +0000
Message-ID: <E1q71Nj-000fD1-NC@gemulon.postgresql.org> (raw)

Don't use _BitScanForward64/_BitScanReverse64 on 32-bit MSVC builds

677319746 added support for making use of MSVC's bit scanning functions.
However, that commit failed to consider 32-bit MSVC builds where the
64-bit versions of these functions are unavailable.  This resulted in
compilation failures on 32-bit MSVC.

Here we adjust the code so we fall back on the manual way of finding the
bit positions for 64-bit integers when building on 32-bit MSVC.

Bug: #17967
Reported-by: Youmiu Mo
Discussion: https://postgr.es/m/17967-cd21e34a314141b2@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/53ea2b7ad050ce4ad95c89bb55197209b65886a1

Modified Files
--------------
src/include/port/pg_bitutils.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)



Message-ID: <E1q71Nj-000fD1-NC@gemulon.postgresql.org>
Permalink:  ../E1q71Nj-000fD1-NC@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1q71Nj-000fD1-NC@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Don't use _BitScanForward64/_BitScanReverse64 on 32-bit MSVC bui
  In-Reply-To: <E1q71Nj-000fD1-NC@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox