pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Re-allow INDEX_VAR as rt_index in ChangeVarNodes().
Date: Thu, 08 Jun 2023 17:11:59 +0000
Message-ID: <E1q7JB1-000mtz-8U@gemulon.postgresql.org> (raw)

Re-allow INDEX_VAR as rt_index in ChangeVarNodes().

Apparently some extensions are in the habit of calling
ChangeVarNodes() with INDEX_VAR as the rt_index to replace.
That worked before 2489d76c4, at least as long as there were
not PlaceHolderVars in the expression; but now it fails
because bms_is_member spits up.  Add a test to avoid that.

Per report from Anton Melnikov, though this is not his
proposed patch.

Discussion: https://postgr.es/m/5b370a46-f6d2-373d-9dbc-0d55250e82c1@inbox.ru

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fbf80421ead55deaafbefa808960a2695de492c9

Modified Files
--------------
src/backend/rewrite/rewriteManip.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)



Message-ID: <E1q7JB1-000mtz-8U@gemulon.postgresql.org>
Permalink:  ../E1q7JB1-000mtz-8U@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1q7JB1-000mtz-8U@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Re-allow INDEX_VAR as rt_index in ChangeVarNodes().
  In-Reply-To: <E1q7JB1-000mtz-8U@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox